-
Notifications
You must be signed in to change notification settings - Fork 9
feat(oidc-http-server-pages): generate JSON templates COMPASS-7646 #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Feb 26, 2024
Co-authored-by: Anna Henningsen <[email protected]>
addaleax
reviewed
Feb 27, 2024
0cec587 to
24b7e21
Compare
addaleax
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/COMPASS-7646
Description
The new process of obtaining OIDC HTTP Server Pages:
1. JSON templates are generated at build of
@mongodb-js/oidc-http-server-pagesExample json:
{ "OIDCNotFoundPage": { "parameters": { "productName": "{{prop:ProductName}}" }, "html": "<div>Page not found, product is {{prop:ProductName}}</div>" } }These templates can be used directly by other languages. In devtools-connect, we still have the convenient way of:
2. Pages are requested via
getStaticPageExample usage:
I have tested the pages locally using the
test-oidc-pages.jsscript in devtools-connect. I haven't noticed anything weird and comparing the before-and-after of NotFound Page Source showed no differences. Feel free to double check, especially if you're already familiar with the pages.This is definitely a breaking change for
@mongodb-js/oidc-http-server-pages, but there should be no change in behaviour for@mongodb-js/devtools-connect, which is the only one use externally (as of now). All together, I'd say this is a feat as it brings the JSON templates. I have increased the@mongodb-js/oidc-http-server-pagesmajor version manually.Checklist