Skip to content

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Sep 26, 2025

I'll open a pr off of this one that'll add the add field button to fields.

@Anemy Anemy requested a review from a team as a code owner September 26, 2025 22:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the diagramming library from version 1.5.1 to 1.8.0 and refactors the data modeling code to use new library options, removing custom field display logic and field add button functionality.

  • Simplified field type display by removing custom type formatting and tooltip logic
  • Updated to use new diagramming library callback for field addition
  • Removed deprecated UI components and styling code

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
packages/compass-data-modeling/package.json Bumps @mongodb-js/diagramming dependency from 1.5.1 to 1.8.0
packages/compass-data-modeling/src/utils/nodes-and-edges.ts Removes custom field type display logic, add field button, and updates to use new library API
packages/compass-data-modeling/src/utils/nodes-and-edges.spec.ts Updates tests to reflect simplified field type handling
packages/compass-data-modeling/src/components/diagram-editor.tsx Replaces custom add field button with new library callback

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Anemy Anemy added feature flagged PRs labeled with this label will not be included in the release notes of the next release no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) labels Sep 26, 2025
@Anemy Anemy requested a review from kraenhansen September 29, 2025 08:11
Copy link
Member Author

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json isn't hoisting right, will need changes.

Copy link
Collaborator

@paula-stacho paula-stacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good except the package lock 😅 the named constants are a nice touch!

@kraenhansen
Copy link
Contributor

kraenhansen commented Sep 29, 2025

Had a quick look at this - seems good to me 👍

@Anemy Anemy merged commit 3cd9648 into main Sep 29, 2025
60 checks passed
@Anemy Anemy deleted the COMPASS-9742-bump-diagramming-use-add-field branch September 29, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature flagged PRs labeled with this label will not be included in the release notes of the next release no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants