-
Notifications
You must be signed in to change notification settings - Fork 231
chore(data-modeling): bump diagramming, pass new options, remove related code #7387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the diagramming library from version 1.5.1 to 1.8.0 and refactors the data modeling code to use new library options, removing custom field display logic and field add button functionality.
- Simplified field type display by removing custom type formatting and tooltip logic
- Updated to use new diagramming library callback for field addition
- Removed deprecated UI components and styling code
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/compass-data-modeling/package.json | Bumps @mongodb-js/diagramming dependency from 1.5.1 to 1.8.0 |
packages/compass-data-modeling/src/utils/nodes-and-edges.ts | Removes custom field type display logic, add field button, and updates to use new library API |
packages/compass-data-modeling/src/utils/nodes-and-edges.spec.ts | Updates tests to reflect simplified field type handling |
packages/compass-data-modeling/src/components/diagram-editor.tsx | Replaces custom add field button with new library callback |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-lock.json isn't hoisting right, will need changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good except the package lock 😅 the named constants are a nice touch!
Had a quick look at this - seems good to me 👍 |
I'll open a pr off of this one that'll add the add field button to fields.