Skip to content

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Apr 2, 2025

Description

  • auto correct server publicPath in ssr mode
  • add ssrPublicPath field in snapshot and manifest

before

    "ssrRemoteEntry": {
      "name": "remote-entry.5648e961.js",
      "path": "bundles",
      "type": "commonjs-module"
    },
    "publicPath":"http://localhost:8001/"

after

    "ssrRemoteEntry": {
      "name": "remote-entry.5648e961.js",
-     "path": "bundles",
+     "path": "",
      "type": "commonjs-module"
    },
    "publicPath":"http://localhost:8001/"
+  "ssrPublicPath": "http://localhost:8001/bundles/"

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: 74f5ba9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@module-federation/sdk Patch
@module-federation/modern-js Patch
@module-federation/devtools Patch
@module-federation/cli Patch
@module-federation/data-prefetch Patch
@module-federation/dts-plugin Patch
@module-federation/enhanced Patch
@module-federation/esbuild Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/retry-plugin Patch
@module-federation/rsbuild-plugin Patch
@module-federation/rspack Patch
@module-federation/runtime-core Patch
@module-federation/runtime Patch
@module-federation/storybook-addon Patch
@module-federation/utilities Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/modernjsapp Patch
@module-federation/runtime-tools Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/bridge-shared Patch
@module-federation/error-codes Patch
create-module-federation Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 74f5ba9
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67f342d77ae557000861adb5
😎 Deploy Preview https://deploy-preview-3661--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2heal1 2heal1 changed the title WIP: fix: correct publicpath in build fix: correct publicpath in build Apr 7, 2025
@zhoushaw zhoushaw merged commit 64a2bc1 into main Apr 7, 2025
20 checks passed
@zhoushaw zhoushaw deleted the fix/set-ssr-publicpath branch April 7, 2025 07:39
@2heal1 2heal1 mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants