✨ (client/index.ts): add optional RequestOptions parameter to connect… #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method to allow additional configuration options
|
Could someone please review this? I’ve been stuck on the initialization timeout issue.Thanks! |
|
🆙 We have the same issue, and this PR would fix it |
Pizzaface
pushed a commit
to RewstApp/mcp-inspector
that referenced
this pull request
May 2, 2025
Gracefully handle proxy server and inspector client startup errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optional RequestOptions parameter (options) has been added to the client's connect method for timeout configuration.
Motivation and Context
The client often times out during initialization, so we need to adjust the timeout setting for the initialization reques
How Has This Been Tested?
Yes, the timeout parameter was validated by installing tools like mcp-browser-use that require lengthy dependency installations.
Breaking Changes
No, the options parameter is optional.
Types of changes
Checklist
Additional context