Skip to content

Conversation

@pcarleton
Copy link
Member

@pcarleton pcarleton commented Nov 18, 2025

Motivation and Context

When writing the conformance test: modelcontextprotocol/conformance#36, I discovered 2 issues with our scope management:

  • We don't set the auth header in the requireBearer middleware
  • We don't use scopes_supported from the PRM in the scope passing

How Has This Been Tested?

Added conformance tests

Breaking Changes

This lines us up with the specification

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@pcarleton pcarleton marked this pull request as ready for review November 18, 2025 14:07
@pcarleton pcarleton requested a review from a team as a code owner November 18, 2025 14:07
@pcarleton pcarleton merged commit 2e67eb5 into main Nov 18, 2025
8 of 10 checks passed
@pcarleton pcarleton deleted the pcarleton/scopes-835 branch November 18, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants