fix: #780 onerror and other listener not remove after client close #1043
+58
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter client close (stdio)
|
@ochafik pardon, could you please check if this commit meets requirements? If there are any could be improved, please let me know anytime~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to clean up residual listeners after calling transport.close().
Motivation and Context
see #780
How Has This Been Tested?
After making this modification, residual listeners will not be triggered after closing the transport, and only "close" will be printed in the console.
and past all test suits
Breaking Changes
No breaking changes
Types of changes
Checklist
Additional context