Skip to content

fix: Cargo.toml cleanup #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

fix: Cargo.toml cleanup #298

merged 1 commit into from
Jul 2, 2025
+9 −5

Conversation

@alexhancock
Copy link
Contributor

@alexhancock alexhancock commented Jul 2, 2025

Address failing build for release-plz integration by correcting / updating Cargo.tomls to not publish examples and use workspace across the board for depending on rmcp

Original error:

    failed to publish rig-integration:     Updating crates.io index
    error: all dependencies must have a version specified when publishing.
    dependency `rmcp` does not specify a version
    Note: The published dependency will use the version from crates.io,
    the `path` specification will be removed from the dependency declaration.

https://github.com/modelcontextprotocol/rust-sdk/actions/runs/16030293757/job/45228856027

@alexhancock alexhancock requested review from a team, 4t145 and jokemanfire July 2, 2025 17:04
@github-actions github-actions bot added T-dependencies Dependencies related changes T-config Configuration file changes T-examples Example code changes labels Jul 2, 2025
@alexhancock alexhancock force-pushed the alexhancock/cargo-toml-cleanup branch from b1d8889 to 69b6078 Compare July 2, 2025 17:12
@alexhancock alexhancock force-pushed the alexhancock/cargo-toml-cleanup branch from 69b6078 to 05c7265 Compare July 2, 2025 17:17
@alexhancock alexhancock merged commit ca36901 into main Jul 2, 2025
20 of 21 checks passed
@alexhancock alexhancock deleted the alexhancock/cargo-toml-cleanup branch July 2, 2025 18:26
bug-ops pushed a commit to bug-ops/rust-sdk that referenced this pull request Jul 3, 2025
@alexhancock @bug-ops
fix(build): cargo.toml cleanup (modelcontextprotocol#298)
29706d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jokemanfire jokemanfire Awaiting requested review from jokemanfire

@4t145 4t145 Awaiting requested review from 4t145

1 more reviewer

@salman1993 salman1993 salman1993 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-config Configuration file changes T-dependencies Dependencies related changes T-examples Example code changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexhancock @salman1993