Skip to content

fix: let users decide what to wrap in child process command #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix: let users decide what to wrap in child process command #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions crates/rmcp/src/transport/child_process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,25 @@ impl AsyncRead for TokioChildProcessOut {
}

impl TokioChildProcess {
/// Create a new Tokio child process with the given command.
///
/// # Manage the child process
/// You can also check these issue and pr for more information on how to manage the child process:
/// - [#156](https://github.com/modelcontextprotocol/rust-sdk/pull/156)
/// - [#253](https://github.com/modelcontextprotocol/rust-sdk/issues/253)
/// ```rust,ignore
/// #[cfg(unix)]
/// command_wrap.wrap(process_wrap::tokio::ProcessGroup::leader());
/// #[cfg(windows)]
/// command_wrap.wrap(process_wrap::tokio::JobObject);
/// ```
///
pub fn new(command: impl Into<TokioCommandWrap>) -> std::io::Result<Self> {
let mut command_wrap = command.into();
command_wrap
.command_mut()
.stdin(std::process::Stdio::piped())
.stdout(std::process::Stdio::piped());
#[cfg(unix)]
command_wrap.wrap(process_wrap::tokio::ProcessGroup::leader());
#[cfg(windows)]
command_wrap.wrap(process_wrap::tokio::JobObject);
let (child, (child_stdout, child_stdin)) = child_process(command_wrap.spawn()?)?;
Ok(Self {
child: ChildWithCleanup { inner: child },
Expand Down
Loading