Skip to content

Conversation

@okoyfoeciov
Copy link
Contributor

Disable wasmbind feature in chrono for wasm32-unknown-unknown target.

Motivation and Context

My code couldn't compile when I use it on a non-browser WASM runtime due to chrono wasmbind feature implicitly pull in js-sys crate. The v0.5.x version has fixed that, but currently not been published yet.

See more:

How Has This Been Tested?

It doesn't interrupt any current behaviors.

Breaking Changes

It doesn't interrupt any current behaviors.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

4t145
4t145 previously approved these changes May 28, 2025
Copy link
Collaborator

@4t145 4t145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@4t145
Copy link
Collaborator

4t145 commented May 28, 2025

dependency (chrono) specified without providing a local path, Git repository, version, or workspace dependency to use

please fix this error of ci

@okoyfoeciov
Copy link
Contributor Author

dependency (chrono) specified without providing a local path, Git repository, version, or workspace dependency to use

please fix this error of ci

@4t145 Hope it works this time. See: https://doc.rust-lang.org/beta/rustc/platform-support/wasm32-unknown-unknown.html#conditionally-compiling-code

@okoyfoeciov okoyfoeciov requested a review from 4t145 May 28, 2025 13:54
@4t145 4t145 merged commit 9fc6af0 into modelcontextprotocol:main May 28, 2025
@github-actions github-actions bot mentioned this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants