Skip to content

Conversation

@wenhaozhao
Copy link
Contributor

Motivation and Context

When the MCP server, connected via SSE, returns an endpoint event with a data value that starts with / (e.g., /mcp/message?sessionId=...), the SDK appears to be using this absolute path directly without considering the base URL of the initial SSE connection. This results in the client attempting to access an incorrect URL.

How Has This Been Tested?

maybe it require a api-gateway server

Breaking Changes

Nope

Types of changes

  • [✅ ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • [ ✅ ] I have read the MCP Documentation
  • [ ✅ ] My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Collaborator

@4t145 4t145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@4t145
Copy link
Collaborator

4t145 commented May 7, 2025

Fix clippy and commit message ci please. And you may merge the code in main branch firstly, we just fixed a bug in test.

@4t145
Copy link
Collaborator

4t145 commented May 18, 2025

I fixed this in #167 so I will closed this one. Thanks for your PR.

@4t145 4t145 closed this May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants