[test] only load reporters when outside of rubymine test runner #97
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jul 30, 2025
| unless ENV["RM_INFO"] | ||
| # RubyMine does not support Minitest reporters, so we use the default reporter | ||
| Minitest::Reporters.use!(Minitest::Reporters::ProgressReporter.new) | ||
| end |
There was a problem hiding this comment.
There is concern about the inclusion of the RubyMine-specific environment variable "RM_INFO", which depends on the local environment. It may be worth reconsidering whether Minitest::Reporters configuration is necessary in the first place. If not, removing the use of Minitest::Reporters might be the simpler option.
There was a problem hiding this comment.
Minitest::Reporters is definitely not critical to anything the test suite is doing, it's just an fancy progress bar when running the tests
There was a problem hiding this comment.
Yeah, if the appearance of the test progress isn't important, removing it might be the simplest solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable Minitest::Reporters when running tests in RubyMine
Motivation and Context
I want to execute tests directly in ruby mine and Minitest::Reporters is not compatible with RubyMine test runner
How Has This Been Tested?
Locally running tests in and outside of RubyMine
Breaking Changes
none
Types of changes
Checklist