Remove json-schema limit and reorganize dev deps
#68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing conflicts in applications using `json-schema` 5.x. The only breaking change in 5.0 was dropping support for old Ruby versions, which we don't support either.
koic
approved these changes
Jun 19, 2025
Member
koic
left a comment
koic
left a comment
There was a problem hiding this comment.
I like this change. I was also considering moving the add_development_dependency entries to the Gemfile :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We're currently limiting the
json-schemagem to~> 4.1, which means applications using a5.xversion get a dependency conflict. This addresses that.While I was at it, I also moved all development dependencies to
Gemfilefor consistency.How Has This Been Tested?
No, but the only breaking change in
[email protected]'s changelog is dropping support for Ruby versions older than the minimum one we support.Breaking Changes
None
Types of changes
Checklist
I have added appropriate error handlingI have added or updated documentation as neededAdditional context