Skip to content

Conversation

@kfischer-okarin
Copy link
Contributor

I added all missing methods & capability checks (and refactored both tests & implementation to be more declarative)

Motivation and Context

Not all capabilities and methods were checked.

How Has This Been Tested?

Not really - but the existing server tests pass.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

This is not yet adding the actual capability checks to the notification methods - that I'd add in another short PR

@atesgoral
Copy link
Contributor

@kfischer-okarin Do you prefer to fix forward the existing way or do #61 instead? cc @topherbullock @koic

@kfischer-okarin
Copy link
Contributor Author

@atesgoral Thanks for checking the PR!

This PR and #61 are intended to be independent of each other.

#61 is about how capabilities are defined whereas this PR is about how they are used - for now just adding missing capability checks and constants - whether the other PR is accepted or not should have no influence on this PR.

@koic koic merged commit 13bee9f into modelcontextprotocol:main Jul 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants