Unpack settings in FastMCP #1198
Conversation
| debug: bool = False, | ||
| log_level: Literal["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"] = "INFO", | ||
| host: str = "127.0.0.1", | ||
| port: int = 8000, | ||
| mount_path: str = "/", | ||
| sse_path: str = "/sse", | ||
| message_path: str = "/messages/", | ||
| streamable_http_path: str = "/mcp", | ||
| json_response: bool = False, | ||
| stateless_http: bool = False, | ||
| warn_on_duplicate_resources: bool = True, | ||
| warn_on_duplicate_tools: bool = True, | ||
| warn_on_duplicate_prompts: bool = True, | ||
| dependencies: Collection[str] = (), | ||
| lifespan: Callable[[FastMCP[LifespanResultT]], AbstractAsyncContextManager[LifespanResultT]] | None = None, | ||
| auth: AuthSettings | None = None, | ||
| transport_security: TransportSecuritySettings | None = None, |
There was a problem hiding this comment.
This is the main change. The rest is just to comply with those types.
| port: int = 8000, | ||
| mount_path: str = "/", | ||
| sse_path: str = "/sse", | ||
| message_path: str = "/messages/", |
There was a problem hiding this comment.
| message_path: str = "/messages/", | |
| message_path: str = "/messages", |
There was a problem hiding this comment.
Hard to trust AI nowadays. 👀
There was a problem hiding this comment.
Oh, actually, the AI didn't make a mistake.
The default on Settings.message_path was added with the /.
There was a problem hiding this comment.
yea i know :(, is that correct tho?
There was a problem hiding this comment.
Given that it doesn't follow the pattern, no. But also there's some redirect issues that people may be facing.
But should I really change it in this PR? It may affect people.
| log_level: Literal["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"] = "INFO", | ||
| host: str = "127.0.0.1", | ||
| port: int = 8000, | ||
| mount_path: str = "/", | ||
| sse_path: str = "/sse", | ||
| message_path: str = "/messages/", | ||
| streamable_http_path: str = "/mcp", | ||
| json_response: bool = False, | ||
| stateless_http: bool = False, | ||
| warn_on_duplicate_resources: bool = True, | ||
| warn_on_duplicate_tools: bool = True, | ||
| warn_on_duplicate_prompts: bool = True, | ||
| dependencies: Collection[str] = (), | ||
| lifespan: Callable[[FastMCP[LifespanResultT]], AbstractAsyncContextManager[LifespanResultT]] | None = None, | ||
| auth: AuthSettings | None = None, | ||
| transport_security: TransportSecuritySettings | None = None, |
There was a problem hiding this comment.
My main worry is that we now keep the defaults in sync between Settings and this. I think ideally, but sadly a BC break would be to just accept settings: Settings = Settings() here. Since I think that would be backwards incompatible. For now, since Settings is only used internally to FastMCP should we remove the defaults from the Settings class, such that we only provide it here?
There was a problem hiding this comment.
Yep, we should remove the defaults from Settings.
No description provided.