[Server] Switch to set* and add* on ServerBuilder instead of with* #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
changed the title
|
Perfect! |
chr-hertel
force-pushed
the
refactor-server-builder-api
branch
from
724f2f9 to
b80b4cc
Compare
CodeWithKyrian
previously approved these changes
Sep 14, 2025
chr-hertel
force-pushed
the
refactor-server-builder-api
branch
from
b80b4cc to
1d8b482
Compare
CodeWithKyrian
approved these changes
Sep 14, 2025
|
Related to #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By renaming the
with*methods on theServerBuildertoset*andadd*methods, it is more explicit to developers using it that there is no cloning going on and if they override or extend the state of the ServerBuilder.cc @butschster