[Server] Fix return type in abstract methods from self
to static
#53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed return type from
self
tostatic
infromArray()
method and abstractfromParams()
method to fix polymorphism issues.Motivation and Context
Using
self
as return type breaks polymorphic behavior sinceself
always refers to the abstract parent class, whilestatic
refers to the actual subclass being called at runtime.This ensures subclasses return the correct type when calling these methods.
How Has This Been Tested?
Not tested - this is a type annotation fix only, runtime behavior unchanged.
Breaking Changes
Minor breaking change in type annotations only. Runtime behavior remains the same.
Types of changes
Checklist
Additional context
Simple type annotation fix: