Restructure link buttons in sidebar to respect theme #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olaservo
reviewed
Mar 24, 2025
Member
|
@morinokami I'm not sure what conditions you're in when seeing those black buttons in the before picture. This is what it currently looks like for me (Chrome on Mac) |
Contributor
Author
|
@cliffhall I'm also testing this on Chrome for macOS. The screenshots I shared above reflect what I'm seeing, though it seems a bit different from yours... Does the appearance match when you run the updated code? |
olaservo
reviewed
Mar 28, 2025
Member
|
@cliffhall I'm seeing the same before/after as in @morinokami 's screenshots. I'm using Chrome on Windows. |
olaservo
approved these changes
Mar 28, 2025
Member
|
Super weird that I was never seeing the before image. I went back and tried versions of the inspector going to 0.5.0 and still never saw the problem. Even tried it in Safari and FireFox. But if others saw it and this fixed it, right on. 👍 |
IgnacioC44
referenced
this pull request
in MCPJam/inspector
Jun 21, 2025
Restructure link buttons in sidebar to respect theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sidebar icon buttons to properly respect theme settings in both light and dark modes.
Motivation and Context
The documentation, debugging, and GitHub icon buttons in the sidebar were difficult to see. This change ensures the buttons properly inherit theme colors for better visibility and consistency.
How Has This Been Tested?
Breaking Changes
None.
Types of changes