Skip to content

mcp: changed streamID's from int64 to random strings #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

mcp: changed streamID's from int64 to random strings #266

merged 1 commit into from
Aug 15, 2025

Conversation

2bitburrito
Copy link
Contributor

  • Changed StreamID's to store randomly generated strings.
  • Created a defaultStreamID field on the StreamableServerTransport struct which is generated and saved on instansiation.
  • Updated all tests.

Fixes #259

jba
jba requested changes Aug 8, 2025
View reviewed changes
@2bitburrito
Copy link
Contributor Author

Ok - thanks for the notes. I apprecaite the feedback and apologies if there are any further issues. I haven't done much open-source stuff before.

I have:

  • Removed the defaultStreamID implementation and just used an empty string for the default stream.
  • Updated the comment to not include implementation details
  • Fixed the auto-formatted issue
  • Added an extra test in TestEventID that ensure's StreamID's can be empty strings.

Thanks, let me know how that looks and whether there's anything else you'd recommend.

Hugh

jba
jba requested changes Aug 11, 2025
View reviewed changes
@2bitburrito
Copy link
Contributor Author

Hi Jonathan, I've made those changes now.

jba
jba previously approved these changes Aug 12, 2025
View reviewed changes
@jba
Copy link
Contributor

jba commented Aug 12, 2025

Now please resolve conflicts.

@2bitburrito
mcp: changed streamID's from int64 to random strings (modelcontextpro…
b468679 
…tocol#266)

- Changed StreamID's to store randomly generated strings.
- Updated all tests.
- Resolved conflicts
@2bitburrito
Copy link
Contributor Author

Hi Jonathan,
All conflicts are resolved.
I have also sqashed that down to a single commit to keep it clean too. Let me know if there are any issues.

@findleyr findleyr merged commit 0a8fe40 into modelcontextprotocol:main Aug 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jba jba jba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stream IDs should be random strings
3 participants
@2bitburrito @jba @findleyr