mcp: add syntax and scheme validation to AddResourceTemplate #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samthanawalla could you help review? |
samthanawalla
requested changes
Aug 19, 2025
mcp/server.go
Outdated
| // Validate the URI template syntax | ||
| _, err := uritemplate.New(t.URITemplate) | ||
| if err != nil { | ||
| panic(fmt.Errorf("URI template %s is invalid: %v", t.URITemplate, err)) |
There was a problem hiding this comment.
wrap the error with %w instead of %v
mcp/server.go
Outdated
| panic(err) // url.Parse includes the URI in the error | ||
| } | ||
| if !u.IsAbs() { | ||
| panic(fmt.Errorf("URI template %s needs a scheme", t.URITemplate)) |
There was a problem hiding this comment.
use %q instead of %s to quote the string
mcp/server.go
Outdated
| // Validate the URI template syntax | ||
| _, err := uritemplate.New(t.URITemplate) | ||
| if err != nil { | ||
| panic(fmt.Errorf("URI template %s is invalid: %v", t.URITemplate, err)) |
There was a problem hiding this comment.
use %q instead of %s to quote the string
There was a problem hiding this comment.
All done. Thank you for the review!
samthanawalla
approved these changes
Aug 19, 2025
jba
approved these changes
Aug 19, 2025
| if !tt.expectPanic { | ||
| t.Errorf("%s: unexpected panic: %v", tt.name, r) | ||
| } | ||
| } else { |
yasomaru
pushed a commit
to yasomaru/go-sdk
that referenced
this pull request
Aug 28, 2025
…ntextprotocol#253) Add template validation and scheme check in `AddResourceTemplate`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change:
To avoid silent failures caused by invalid URI template, this PR:
AddResourceTemplate, panic if the template is invalid or lacks a schemeWe recently encountered an internal issue where a malformed template was mistakenly added. It could never match any URI, and since the current
Matchesimplementation returnsfalseon parse errors without logging, it silently failed and made debugging harder.If this validation is not aligned with intended behavior (e.g. if template correctness is considered caller responsibility), happy to close this PR. Just wanted to raise it after hitting a subtle failure in practice.
go-sdk/mcp/resource.go
Lines 157 to 164 in b392875