Skip to content

Enable netfx testing. #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 8, 2025
Merged

Enable netfx testing. #588

merged 5 commits into from
Jul 8, 2025

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Jul 4, 2025 •
edited
Loading

This PR attempts to turn on netfx testing for the main ModelContextProtocol.Tests project. Makes the following changes:

  1. Polyfills the StreamReader implementation from .NET Core so that cancellable ReadLine() calls are supported, preventing deadlocks during disposal.
  2. Turns on netfx testing for non-Windows platforms using mono.

Note that some tests have been disabled on netfx (but not on mono) due to #587

@eiriktsarpalis eiriktsarpalis marked this pull request as ready for review July 7, 2025 15:48
@eiriktsarpalis eiriktsarpalis merged commit aa75f6f into modelcontextprotocol:main Jul 8, 2025
7 checks passed
@eiriktsarpalis eiriktsarpalis deleted the enable-netfx-testing branch July 8, 2025 15:50
@stephentoub stephentoub mentioned this pull request Jul 15, 2025
Closed
@dependabot dependabot bot mentioned this pull request Jul 22, 2025
Closed
@eiriktsarpalis eiriktsarpalis mentioned this pull request Jul 29, 2025
Closed
This was referenced Aug 1, 2025
Merged
Merged
@dependabot dependabot bot mentioned this pull request Aug 11, 2025
Merged
@dependabot dependabot bot mentioned this pull request Aug 25, 2025
Merged
microsoft-github-policy-service bot pushed a commit to Azure/bicep that referenced this pull request Aug 25, 2025
@dependabot
Bump ModelContextProtocol from 0.3.0-preview.2 to 0.3.0-preview.4 (#1…
034413c 
…7897)

Updated
[ModelContextProtocol](https://github.com/modelcontextprotocol/csharp-sdk)
from 0.3.0-preview.2 to 0.3.0-preview.4.

<details>
<summary>Release notes</summary>

_Sourced from [ModelContextProtocol's
releases](https://github.com/modelcontextprotocol/csharp-sdk/releases)._

## 0.3.0-preview.4

## What's Changed
* Respect HandleResponse() and SkipHandler() calls in
OnResourceMetadataRequest by @​halter73 in
modelcontextprotocol/csharp-sdk#607
* UnreferenceDisposable made slimmer by @​Scooletz in
modelcontextprotocol/csharp-sdk#627
* IdleTracking uses lists instead of SortedSet by @​Scooletz in
modelcontextprotocol/csharp-sdk#629
* Fix ResourceLinkBlock deserialization by adding missing "name" case by
@​Copilot in modelcontextprotocol/csharp-sdk#645
* Add an in-memory transport sample by @​stephentoub in
modelcontextprotocol/csharp-sdk#664
* Remove 'Sse' from AspNetCoreSseServer sample name by @​halter73 in
modelcontextprotocol/csharp-sdk#665
* Fix NotSupportedException when returning IEnumerable<ContentBlock> by
@​Copilot in modelcontextprotocol/csharp-sdk#675
* Enhance HTTP and MCP session logging by @​theojiang25 in
modelcontextprotocol/csharp-sdk#608
* Remove special-casing of string enumerables in McpServerTool by
@​stephentoub in
modelcontextprotocol/csharp-sdk#699
* Prune idle sessions before starting new ones by @​halter73 in
modelcontextprotocol/csharp-sdk#701
* Add framework for conceptual docs by @​mikekistler in
modelcontextprotocol/csharp-sdk#708

## New Contributors
* @​Scooletz made their first contribution in
modelcontextprotocol/csharp-sdk#627
* @​Copilot made their first contribution in
modelcontextprotocol/csharp-sdk#645
* @​theojiang25 made their first contribution in
modelcontextprotocol/csharp-sdk#608

**Full Changelog**:
modelcontextprotocol/csharp-sdk@v0.3.0-preview.3...v0.3.0-preview.4

## 0.3.0-preview.3

## What's Changed
* Enable netfx testing. by @​eiriktsarpalis in
modelcontextprotocol/csharp-sdk#588
* fix: Prevent crash when Options.ResourceMetadata is null but handled
by event by @​DavidParks8 in
modelcontextprotocol/csharp-sdk#603
* Update to M.E.AI 9.7.0 by @​stephentoub in
modelcontextprotocol/csharp-sdk#602
* Ensure IsExternalInit is type forwarded on NET builds by @​stephentoub
in modelcontextprotocol/csharp-sdk#619
* Flow ExecutionContext with JsonRpcMessage by @​halter73 in
modelcontextprotocol/csharp-sdk#616
* Update MEAI version and add regression test for #​601. by
@​eiriktsarpalis in
modelcontextprotocol/csharp-sdk#628

## New Contributors
* @​DavidParks8 made their first contribution in
modelcontextprotocol/csharp-sdk#603

**Full Changelog**:
modelcontextprotocol/csharp-sdk@v0.3.0-preview.2...v0.3.0-preview.3

Commits viewable in [compare
view](modelcontextprotocol/csharp-sdk@v0.3.0-preview.2...v0.3.0-preview.4).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ModelContextProtocol&package-manager=nuget&previous-version=0.3.0-preview.2&new-version=0.3.0-preview.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/17897)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eiriktsarpalis @halter73