Overhaul of Resources #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introducing separate classes for Text and Blob ResourceContents - Custom JSON converter to allow those types to be returned, making it easier to follow the type system against the spec - Updated tests
stephentoub
reviewed
Mar 28, 2025
src/ModelContextProtocol/Protocol/Types/Resources/BlobResourceContents.cs
Outdated
Show resolved
Hide resolved
src/ModelContextProtocol/Protocol/Types/Resources/ResourceContents.cs
Outdated
Show resolved
Hide resolved
src/ModelContextProtocol/Protocol/Types/Resources/ResourceContents.cs
Outdated
Show resolved
Hide resolved
PederHP
reviewed
Mar 28, 2025
src/ModelContextProtocol/Protocol/Types/Resources/TextResourceContents.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <[email protected]> Co-authored-by: Peder Holdgaard Pedersen <[email protected]>
stephentoub
reviewed
Mar 30, 2025
src/ModelContextProtocol/Protocol/Types/BlobResourceContents.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 30, 2025
stephentoub
reviewed
Mar 30, 2025
stephentoub
reviewed
Mar 30, 2025
stephentoub
reviewed
Mar 30, 2025
stephentoub
reviewed
Mar 30, 2025
stephentoub
reviewed
Mar 30, 2025
stephentoub
reviewed
Mar 30, 2025
stephentoub
reviewed
Mar 30, 2025
stephentoub
approved these changes
Mar 30, 2025
Contributor
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Once the remaining comments are addressed, LGTM. Thanks!
Co-authored-by: Stephen Toub <[email protected]>
stephentoub
reviewed
Mar 31, 2025
Contributor
Author
Fixed that one and I think I got the merge correct from your change (and I fixed that at the same time) |
stephentoub
approved these changes
Mar 31, 2025
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the Resources and ResourceTemplates part of the MCP server which aims to align the data structures more with the structure that we see in the spec (using 2024-11-05 as the spec target).
WithReadResourceHandlershould work if you only provideWithListResourceTemplatesHandler#123 by allowing a ListResourceTemplates handler to work in conjunction with ReadResourcesRequestRather than using
ResourceContentsas a combination of the properties across blob and text resources, I've turned this into an abstract class and have implementations of the types. This more closely aligns with the structure we see in the schema, making it easier to map our types to the source types.