Add conformance tests for SEP-1330 elicitation enums #22
+647
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Collaborator
Author
|
Tested together with modelcontextprotocol/typescript-sdk#1100 
|
KKonstantinov
approved these changes
Nov 11, 2025
Adds server-side conformance test that validates servers properly request elicitation with SEP-1330 enum schema improvements: - Untitled single-select enum (type: string, enum: [...]) - Titled single-select enum (oneOf with const/title) - Legacy titled enum (enumNames for backward compatibility) - Untitled multi-select enum (type: array, items.enum) - Titled multi-select enum (items.anyOf with const/title) Test expects server to implement `test_elicitation_sep1330_enums` tool.
Adds test_elicitation_sep1330_enums tool to everything-server that requests elicitation with all 5 enum schema variants. Also updates SERVER_REQUIREMENTS.md with full specification.
felixweinberger
force-pushed
the
fweinberger/sep-1330-test
branch
from
63500ac to
204160b
Compare
* refactor maps to pull names from the test * bring names back * separate active from pending * only test active
pcarleton
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds conformance tests for SEP-1330, which improves elicitation enum schema support using JSON Schema's oneOf/const/title pattern.
Tests included:
enumarray (type: string + enum)oneOfwithconst/titlepairs (SEP-1330 recommended)enumNamesalongsideenum(deprecated but supported)items.enum(type: array)items.anyOfwithconst/titlepairs (SEP-1330 recommended)Implementation:
elicitation-sep1330-enumstest_elicitation_sep1330_enumsTesting
The conformance tests are designed to validate that servers properly construct elicitation requests with the correct JSON Schema patterns for enum types. These tests require an SDK implementation that supports SEP-1330.
Related
Breaking Changes
None.
Checklist