Contracts and Harnesses for <*const T>::byte_add, byte_sub and byte_offset
#177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds harnesses for int, unit, composite and slice types
Author
|
@feliperodri FYI |
|
May I suggest you close this PR and incorporate these changes into #169? The contracts and harnesses are almost identical, so I think any comments you get on one PR will apply to the other. It's easier for us to review them all at once than have separate PRs with separate reviewers. |
Author
|
Sure @carolynzech! That makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #76
Changes
<*mut T>::byte_add,<*mut T>::byte_suband<*mut T>::byte_offset.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.