Skip to content

add summed bypass (to enable delay tails to go on after bypassing) #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add summed bypass (to enable delay tails to go on after bypassing) #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20bacae
add summed bypass (to enable delay tails to go on after bypassing)
fps Oct 8, 2022
fc55fe6
make summed bypass unconditional again
fps Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/effects.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1963,6 +1963,14 @@ static int ProcessPlugin(jack_nframes_t nframes, void *arg)
/* Run the plugin with zero buffer to avoid 'pause behavior' in delay plugins */
lilv_instance_run(effect->lilv_instance, nframes);

for (i = 0; i < effect->output_audio_ports_count; i++)
{
float *buffer_out = (float*)jack_port_get_buffer(effect->output_audio_ports[i]->jack_port, nframes);
for (jack_nframes_t frame = 0; frame < nframes; ++frame)
{
buffer_out[frame] += ((float*)effect->output_audio_ports[i]->buffer)[frame];
}
}
/* no need to silence plugin audio or cv, they are unused during bypass */
}
/* Plugins without audio inputs */
Expand Down