add option to turn off https repo url to private recipes #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR contains the changes fixs of #11 because the compiled js. |
|
Rebased after after #11 has been merged. |
|
Thanks for the cleanup. I thought on this issue and I think we should rethink the solution. It does not feel right to inject the information on https or not into the status report config only to have the variable available in the ui. A better solution would be to integrate this information into the git repo class and have it available there. The repo should have it's own propery What do you think on that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is because sometimes privates git server has ssh url enabled, but not have https url enabled. Example: i'm using a private gitlab server with ssh enabled, but i not use https on this server.
Currentily, if a private recipes repo has a git ssh url, the recipes url is always https.