Update to MMTk core PR #875 #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinsoon
added a commit
that referenced
this pull request
Aug 14, 2023
This PR is based on #86. * Move stack scanning code to Rust, and implement `Scanning::scan_roots_in_mutator_thread`. * Implement necessary types/functions in Rust. * It is not necessary to implement this in Rust. However, it needs to use `scan_gcstack()`, which is implemented in Rust, and used for object scanning. It would be better to remove our implementation for it in C. * Create `scan_vm_specific_roots`, and call it in `Scanning::scan_vm_specific_roots`. * Allow using `RootsWorkFactory` in C * Remove global `ROOT_NODES/EDGES` as they are no longer used. * Add assertions to check type size for our Rust and C types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to mmtk/mmtk-core#875.