Skip to content

Update to MMTk core PR #817 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 26, 2023
Merged

Update to MMTk core PR #817 #58

merged 4 commits into from
May 26, 2023

Conversation

@qinsoon
Copy link
Member

@qinsoon qinsoon commented May 17, 2023 •
edited
Loading

Update for mmtk/mmtk-core#817.

@qinsoon qinsoon marked this pull request as ready for review May 17, 2023 05:13
wks
wks requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not safe to assume the layout of the Box type, but we can convert it to and from raw pointers to make it interoperable with C.

wks
wks approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit 936a9aa into mmtk:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wks wks wks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qinsoon @wks