Skip to content

Conversation

@udesou
Copy link
Contributor

@udesou udesou commented Oct 10, 2024

This PR updates update-ready/immix to support its counterpart in mmtk/julia. It should enable MMTk to run with the latest upstream Julia, but currently supporting only non-moving immix. It also cleans up the binding code, removing the C files and moving it into the Julia repo (gc-mmtk.c). Finally, it removes the duplication that we had to use Bindgen, and instead generates the Rust bindings using a build.rs file.

@udesou udesou requested a review from qinsoon October 10, 2024 23:37
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to remove the julia folder and move the files to the Julia repo?

Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. After removing the C source from the binding, and introducing bindgen to our build process, it is much cleaner.

@udesou udesou requested a review from qinsoon October 18, 2024 04:10
@udesou udesou merged commit c131283 into mmtk:upstream-ready/immix Oct 18, 2024
5 checks passed
@udesou udesou mentioned this pull request Oct 18, 2024
udesou added a commit that referenced this pull request Oct 24, 2024
Backporting #180, merge with
mmtk/julia#67.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants