Skip to content

Conversation

@qinsoon
Copy link
Member

@qinsoon qinsoon commented Jul 20, 2023

No description provided.

@qinsoon
Copy link
Member Author

qinsoon commented Jul 20, 2023

I am wondering if we still need the 'counted' interface. With #866, we may be able to completely remove the current 'counted malloc' methods.

@wks
Copy link
Collaborator

wks commented Jul 20, 2023

I am wondering if we still need the 'counted' interface. With #866, we may be able to completely remove the current 'counted malloc' methods.

I think it is still part of our plan to provide an implementation of malloc using MMTk's allocators and collectors. So we probably still need those interfaces. But whether the interface should remain in its current form is a different question.

And its implementation needs to be improved, too. Currently it wraps the malloc from naive libraries (such as libc) and we account the memory by bytes. But currently I don't see any urgent need (at least for the Ruby binding) for an implementation of malloc provided by the MMTk core.

We may need to address issues such as providing an implicit global instance of MMTK (or just the necessary part) so that we can replace the global malloc function (and probably allow using LD_PRELOAD to replace the malloc implementation). We may also need to allow per-MMTk malloc implementation so that the user can malloc into a given MMTk instance (which is like the current API).

@qinsoon
Copy link
Member Author

qinsoon commented Jul 20, 2023

We need the malloc interface. But we do not necessarily need the 'counted malloc' interface. I will see if I can change the Julia binding to use the vm_live_bytes to replace the current use of 'counted malloc'.

@qinsoon
Copy link
Member Author

qinsoon commented Aug 1, 2023

Closing this PR. The julia binding is not using the counted malloc APIs (mmtk/mmtk-julia#80), and we do not need to add more. We may consider removing those APIs.

@qinsoon qinsoon closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants