Update dependencies versions #756
Conversation
enum-map-derive requires 1.61
|
LGTM. This PR upgrades our minimal supported Rust version. I think we should update our bindings first, then merge this. Otherwise, our bindings cannot run with the latest mmtk-core. We will have a release at the end of this week, and we could update the binding's MSRV when we bump the version for the bindings. |
|
@wks I pushed a change so when we test bindings with a PR, we use the Rust toolchain version in the PR for the bindings. I think this probably makes more sense, as the tests are initiated from mmtk-core. The MSVR and the toolchain specified in the binding should be updated in the binding when the binding uses a new mmtk-core commit as their dependency. |
qinsoon
added
the
PR-testing
|
binding-refs |
|
The binding tests should pass (except v8). I will keep an eye on this, and fix if there is any problem. Once everything works, I will merge it. |
Some dependencies have new versions. It is a good chance to bump the dependency versions, too, after we bump the Rust toolchain versions. One notable dependency is `enum-map`. Its latest version is 2.4.2, but we locked its version to 2.1.0 because it required a newer Rust toolchain. Now we can depend on its latest version, instead. We also changed the `rust-version` property in `Cargo.toml` to `1.61.0` because `enum-map-derive` depends on that, and `1.61.0` is not new compared to the `1.66.1` we use. See: mmtk#507 (comment) This closes mmtk#693
2 participants
Some dependencies have new versions. It is a good chance to bump the dependency versions, too, after we bump the Rust toolchain versions.
One notable dependency is
enum-map. Its latest version is 2.4.2, but we locked its version to 2.1.0 because it required a newer Rust toolchain. Now we can depend on its latest version, instead. We also changed therust-versionproperty inCargo.tomlto1.61.0becauseenum-map-derivedepends on that, and1.61.0is not new compared to the1.66.1we use. See: #507 (comment)This closes #693