Skip to content

Conversation

@wks
Copy link
Collaborator

@wks wks commented Oct 17, 2022

The bit operations of sub-byte fetch_and_atomic and fetch_or_atomic was incorrect, and is fixed in this commit.

The bit operations of sub-byte fetch_and_atomic and fetch_or_atomic was
incorrect, and is fixed in this commit.
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change for header metadata does not seem correct.

@qinsoon qinsoon added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Oct 18, 2022
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit 30771e1 into mmtk:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants