Skip to content

Rename primary of BasePlan and CommonPlan to full_heap #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2021
Merged

Rename primary of BasePlan and CommonPlan to full_heap #447

merged 2 commits into from
Sep 17, 2021

Conversation

@caizixian
Copy link
Member

@caizixian caizixian commented Sep 17, 2021

Close #435

@caizixian caizixian requested a review from qinsoon September 17, 2021 04:21
@caizixian caizixian changed the title Rename primay to full_heap Rename primary to full_heap Sep 17, 2021
@caizixian caizixian requested a review from wenyuzhao September 17, 2021 04:23
@caizixian caizixian changed the title Rename primary to full_heap Rename primary of BasePlan and CommonPlan to full_heap Sep 17, 2021
qinsoon
qinsoon approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caizixian caizixian merged commit 198a142 into master Sep 17, 2021
@caizixian caizixian deleted the issue-435 branch September 17, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qinsoon qinsoon qinsoon approved these changes

@wenyuzhao wenyuzhao Awaiting requested review from wenyuzhao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misleading parameters in prepare and release in CommonPlan and BasePlan

3 participants

@caizixian @qinsoon