Fix Clippy 1.89 warnings #1367
Merged
Fix Clippy 1.89 warnings #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy 1.89 starts to warn about `mismatched_lifetime_syntaxes`. We fix our function signatures by adding `'_` in the return types.
They are used by the VMBinding, but Clippy consider them dead code, too.
qinsoon
approved these changes
Aug 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The OpenJDK minimal test got stuck 10 seconds after running lusearch. https://github.com/mmtk/mmtk-core/actions/runs/16900427294/job/47878439315 As it is happening during mutator time, it is likely there is some problem with the GC-triggering mechanism. But let's leave it to the future. I'll restart the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy 1.89 starts to warn about
mismatched_lifetime_syntaxes. We fix our function signatures by adding'_in the return types.