Update doc comments #1000
Merged
Update doc comments #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-sareen
reviewed
Oct 25, 2023
src/vm/collection.rs
Outdated
|
|
||
| /// Resume all the mutator threads, the opposite of the above. When a GC is finished, MMTk calls this method. | ||
| /// | ||
| /// This method may be called by any GC worker thread, and may not be the same GC worker thread that called |
There was a problem hiding this comment.
That is not correct. At least as of now. Currently the GC controller thread calls resume_mutators in EndOfGC
There was a problem hiding this comment.
See here as well:
mmtk-core/src/scheduler/controller.rs
Lines 140 to 143 in abd38ec
There was a problem hiding this comment.
OK. That's true, although it is not intended. I'll adjust the comment and not mention "worker".
There was a problem hiding this comment.
Random aside, I feel like we should rename stop_all_mutators to suspend_mutators to be in line with resume_mutators.
We no longer have the feature for letting the coordinator call stop_mutators or resume_mutators.
wks
force-pushed
the
fix/stop-mutators-doc
branch
from
7c738ff to
e14f427
Compare
wks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the feature for letting the coordinator call both
stop_all_mutatorsandresume_mutatorssince #794 and #814. The documentation should reflect that.