Skip to content
This repository was archived by the owner on Feb 21, 2022. It is now read-only.

Conversation

hacfi
Copy link
Contributor

@hacfi hacfi commented Nov 6, 2014

Example .formatter.yml:

use-sort:
    group:
        - [Symfony\Component\HttpKernel, Symfony]
        - _main
        - App

to put Symfony\Component\HttpKernel classes on top of the group

Fixes #10

@hacfi
Copy link
Contributor Author

hacfi commented Nov 12, 2014

ping @mmoreram

@mmoreram
Copy link
Owner

@hacfi I've been so busy :( After the Con I will review both PRs and I'll merge them. Thanks for your effort :)

@mmoreram
Copy link
Owner

ping @hacfi I need this feature to be tested properly, and to be ensured that:

  • Has no BCBreaks
  • The new feature is working (I like this feature)

Thanks

@hacfi
Copy link
Contributor Author

hacfi commented Dec 27, 2014

@mmoreram Sorry..overlooked that there are already tests. Will work on them next week.

hacfi added 2 commits January 24, 2015 23:49
Example .formatter.yml:

use-sort:
    group:
        - [Symfony\Component\HttpKernel, Symfony]
        - _main
        - App

to put Symfony\Component\HttpKernel classes on top of the group

Fixes mmoreram#10
@hacfi
Copy link
Contributor Author

hacfi commented Jan 25, 2015

Had a little rebase conflict because of my other PR but all fixed now.

Included a small test for both this PR and #12. Wasn’t sure how to test for no bc breaks but all previous tests passed!?

@hacfi
Copy link
Contributor Author

hacfi commented Feb 11, 2015

@mmoreram anything missing?

@xphere
Copy link

xphere commented Apr 1, 2015

ping @mmoreram 😁

@hacfi
Copy link
Contributor Author

hacfi commented Apr 11, 2015

RTM @mmoreram 😀

@mmoreram
Copy link
Owner

@hacfi Could you please document this feature? Ready to be merged...

@hacfi
Copy link
Contributor Author

hacfi commented Apr 11, 2015

@mmoreram Sure. Just noticed that this feature can’t be used without the config or is there a way to pass an array as a cli argument?

@hacfi
Copy link
Contributor Author

hacfi commented Apr 11, 2015

Fixed some typos while I was at it

mmoreram added a commit that referenced this pull request Apr 13, 2015
Add subgroups to allow sorting within a group
@mmoreram mmoreram merged commit 30eeee2 into mmoreram:master Apr 13, 2015
@xphere
Copy link

xphere commented May 7, 2015

Just found I can't join _main with another namespaces inside same group, like:

use-sort:
    group:
        - [ Symfony, _main ]
        - Elcodi

@hacfi
Copy link
Contributor Author

hacfi commented May 7, 2015

@xphere Will have a look on the weekend..I only had sub-namespaces in mind so didn’t check that.

@mmoreram
Copy link
Owner

mmoreram commented May 7, 2015

Hmmm ok :) Please, fix asap as possible :')

@hacfi
Copy link
Contributor Author

hacfi commented May 7, 2015

I don’t really understand the use-case but will try to fix it asap.

@mmoreram
Copy link
Owner

mmoreram commented May 7, 2015

well, let's find out what the problem is, let's add some tests in order to make them fail, and then, let's fix it 💃

ASk me some help if you need it ! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Additional sorting functions
3 participants