Skip to content
This repository was archived by the owner on Sep 12, 2025. It is now read-only.

Conversation

@allight
Copy link

@allight allight commented Jun 7, 2021

This is useful for some testing applications.

@allight
Copy link
Author

allight commented Jun 7, 2021

Failures seem to be the same ones that appear running cargo test on master.

@jugglerchris
Copy link
Collaborator

Hi,
Thanks for the contribution!
However it's deliberate that load_chunk doesn't load binary/compiled lua files, so this can't be merged as is.
The intention (which hasn't happened yet) is to add a new, unsafe API which does allow loading binary Lua files. See #116 and #145 for some previous discussion.
I think a method on Chunk like:

pub unsafe fn into_function_unsafe(self) -> Result<Function<'lua>>

seems reasonable, but I'd be interested in whether you think that works for your use case.

I'll look into why the CI is failing.

@jugglerchris
Copy link
Collaborator

FWIW I've fixed the CI issues (which I raised separately as #207).

@jugglerchris jugglerchris added this to the Version 1.0 milestone Jul 11, 2021
@jugglerchris
Copy link
Collaborator

This has been addressed as part of #236.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants