ML-9958 remove private image #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| print("Building image for the demo:") | ||
| image_builder = project.set_function( | ||
| "project_setup.py", | ||
| name="image-builder", |
There was a problem hiding this comment.
- You can replace this implementation by using project.build_image that creates an image without creating a function in MLRun
- You can check if there is a
default-imageparameter for the project or check if the project has a default image in the spec.spec.default_imagethat will make sure the image gets built only once, instead of building every time you load the project
Except for this change, LGTM
Contributor
There was a problem hiding this comment.
Agreeing with @GiladShapira94. You can also look at this demo for a reference.
yonishelach
suggested changes
Jun 3, 2025
Contributor
yonishelach
left a comment
yonishelach
left a comment
There was a problem hiding this comment.
Looks good, just a couple of comments.
| print("Building image for the demo:") | ||
| image_builder = project.set_function( | ||
| "project_setup.py", | ||
| name="image-builder", |
Contributor
There was a problem hiding this comment.
Agreeing with @GiladShapira94. You can also look at this demo for a reference.
| project.set_default_image(project.get_param("default_image")) | ||
| project.set_default_image(default_image) | ||
| else: | ||
| project.set_default_image(project.get_param("default_image")) |
Contributor
There was a problem hiding this comment.
The code in the if statement is executed only if there is no default image as a parameter, so the else statement is redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.