Skip to content

Conversation

chfanghr
Copy link
Contributor

No description provided.

@chfanghr chfanghr marked this pull request as draft September 19, 2023 11:08
@chfanghr chfanghr requested a review from adamczykm September 19, 2023 11:08
}

// FIXME: I have no idea what this should do
const getInputs = async (): Promise<string[]> => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this does is basically implemented by fetchPublicInput you wrote

Copy link
Contributor

@adamczykm adamczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving and merging the changes. Once we have an agreed-upon architecture for the plugin class we should probably make the storage a parameter and provide one with some persistence.

@adamczykm
Copy link
Contributor

The PR is marked as WIP, what is your plan? If this is about interaction with the MINA blockchain then it can be done in another PR as another plugin.

@chfanghr chfanghr marked this pull request as ready for review September 20, 2023 09:10
@chfanghr chfanghr merged commit a6c91b4 into develop Sep 20, 2023
adamczykm pushed a commit that referenced this pull request Oct 17, 2023
adamczykm pushed a commit that referenced this pull request Nov 28, 2023
adamczykm pushed a commit that referenced this pull request Nov 28, 2023
adamczykm pushed a commit that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants