Skip to content
This repository was archived by the owner on Nov 2, 2024. It is now read-only.

Conversation

@CarlosLongarela
Copy link

Please check that all is ok (I made the edits in Github).

Finally, my other Slack comment about AAA spec contrast:

Thanks a lot.

@mkaz
Copy link
Owner

mkaz commented Sep 6, 2020

This is going to be a breaking change to existing blocks by changing how attributes are parsed. I need to consider it carefully and also will need to include deprecation to migrate attributes seamlessly.

Good suggestion with the a11y color schemes, I created issue #84 that can address. I've been meaning to allow for multiple color themes for awhile just haven't gotten to implementing.

@CarlosLongarela
Copy link
Author

Ok, understand the compatibility problem, ¿maybe search for data-lang attribute, and if missing, search for lang? Maybe with that approach, all new code blocks would be data-lang and old code blocks as lang, but the user could change it to data-lang without breaking the block.

Issue #84 sounds good

@mkaz
Copy link
Owner

mkaz commented Sep 7, 2020

Hi Carlos, I used your commits and created PR #85 - I extended and added the deprecated property.

Unfortunately, it's not working as expected and I'm still getting an invalid block when opening a block created previously that uses the old attribute. I'm not sure if this is because of how I'm extending a core block or not.

@mkaz
Copy link
Owner

mkaz commented Sep 7, 2020

Closing in favor of #85 (if we can get that one to work)

@mkaz mkaz closed this Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants