Fix bug with reference to the deprecated DEFAULT_COLORS global #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, when will it be released? |
tleonhardt
approved these changes
Dec 28, 2024
|
@mitosch Would it be possible to get this PR merged in an a new release of |
|
|
SameeranB
added a commit
to SameeranB/textual-terminal
that referenced
this pull request
Aug 14, 2025
Fixes mitosch#12 This commit resolves the compatibility issues with Textual v5.3.0+ by: 1. **Remove deprecated imports**: - Removed `from textual.app import DEFAULT_COLORS` - Removed `from textual.design import ColorSystem` 2. **Update detect_textual_colors() method**: - Replace deprecated `self.app.dark` with modern theme detection - Use string-based theme checking: `"dark" in str(self.app.theme).lower()` - Return static color dictionary instead of using ColorSystem.generate() 3. **Version and dependency updates**: - Bump version to 0.4.0 - Update Textual dependency to support >=0.8.0,<6.0.0 - Update README to mention v5.3.0+ compatibility This provides a more robust solution than PR mitosch#11 by completely removing deprecated APIs rather than working around them. The fix has been tested with Textual v5.3.0 and maintains backward compatibility with older versions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Textual updates have rendered textual-terminal unusable. The issue exists when accessing the
DEFAULT_COLORSvariable that no longer exists. This updates the color detection to use Textual's built in theme management.