Respect SERVER_REGION in more targets and fix various bugs
#369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* run gofmt * extend cleanupBucket with argument to control the use of BypassGovernanceRetention. * handle error when cleanupBucket fails * set ObjectLockLegalHoldStatus to a valid value and remove outdated code
This header creates problems as the requests signature is not calculated correctly if it is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone,
I tried using the tool based on main but encountered various errors. I went through them and tried to fix the ones that are relevant to us.
Tbh, I am a bit confused by these errors as they are very surface level. Is the tool actively used inside the minio org?
Please also see the commit bodies as I included some info there.
Proposed changes:
SERVER_REGIONenv variable inaws-sdk-go,aws-sdk-javaandversioningtargetaws-sdk-ruby. Please note that I have no idea what this header might be used for. Removing it might silently break some expectations. However, in it's current form I don't think the request ever succeeded.versioningtarget that caused API errorsObjectLockLegalHoldStatusin line 263Please ping me if I should give more context to the changes.