Adding the first test. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackintoshrao
commented
Dec 23, 2016
hackintoshrao
commented
- Readme with design and usage added.
- First test added.
- Minio-go functional test is used.
hackintoshrao
force-pushed
the
min-go
branch
from
ebcbfe7 to
d8f9377
Compare
- Readme with design and usage added. - First test added. - Minio-go functional test is used.
hackintoshrao
force-pushed
the
min-go
branch
from
d8f9377 to
d5f9f3e
Compare
README.md
Outdated
| ```sh | ||
| - Build and Run. | ||
|
|
||
| $ docker build -t mint:alpha |
Member
There was a problem hiding this comment.
This should be "docker build -t minio/mint:alpha"
README.md
Outdated
| - Build and Run. | ||
|
|
||
| $ docker build -t mint:alpha | ||
| $ docker run -e ENDPOINT=play.minio.io:9000 -e ACCESS_KEY=Q3AM3UQ867SPQQA43P2F -e SECRET_KEY=zuf+tfteSlswRu7BJ86wekitnifILbZam1KYY3TG -e ENABLE_HTTPS=1 mint:alpha |
Member
There was a problem hiding this comment.
One extract space after docker run
minio-go-functional-test/Dockerfile
Outdated
| RUN \ | ||
| apk add --no-cache bash git openssh && \ | ||
| go get -u github.com/minio/minio-go && \ | ||
| go build exec-concurrent.go && \ |
Member
There was a problem hiding this comment.
exec-concurrent.go is not present. yet.. ? is this a future file?
Author
There was a problem hiding this comment.
Yes, This is future file. Will remove it for now.
| RUN \ | ||
| apk add --no-cache bash git openssh && \ | ||
| go get -u github.com/minio/minio-go && \ | ||
| go test -c api_functional_v4_test.go |
Member
There was a problem hiding this comment.
You might have to cd into minio-go directory. Then you don't need to include api_functional_v4_test.go into this project itself.
Author
There was a problem hiding this comment.
Have slight modifications to the test file in terms of using environment variables. Also will be bringing in exec-concurrent .
hackintoshrao
force-pushed
the
min-go
branch
from
9c5d8bb to
8dd1c81
Compare
harshavardhana
approved these changes
Dec 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.