Soft delete

[tmishutin]

Describe the bug
It seems like there is an issue with soft delete. If model using soft delete and result of NOT deleted query is cached, library will ignore global scoping of soft delete scope for the model which will result in wrong return.

Eloquent Query
The following will not find a deleted item

Book::withTrashed()->find($id)

However the following WILL find the deleted item

Book::whereNotNull('deleted_at')->find($id)

Stack Trace

Environment

• PHP:7.2
• OS: Debian stretch
• Laravel: 5.8
• Model Caching: 0.4.11

[jcsoriano]

FWIW, I was also able to replicate this error.

Book::withTrashed()->find($id) doesn't work, but Book::onlyTrashed()->find($id) works fine

Book::withTrashed()->get() also doesn't include the soft-deleted models

Environment:

• PHP: 7.2
• OS: Mac OS
• Laravel: 5.8
• Model Caching: 0.4.13

[mikebronner]

Will investigate soon, thanks for reporting this :)

[mikebronner]

Am working on this, have confirmed that this functionality is missing. Any PR to help with this is welcomed :) The challenge here is "intercepting" the scope created when not using withTrashed() on models that have soft deletes. It doesn't seem to be passed into the query object contained in CachedQueryBuilder :(

[mikebronner]

Good news, while working on fixing how global scopes were parsed, I think I may have found a way to implement this as well. Stay tuned!

[mikebronner]

@tmishutin @jcsoriano Could you guys test release 0.5.5 and let me know how it works for you? This should now be fixed! :) 🎉