Caching of LazyLoaded Relationships

[jradtilbrook]

Issue

From the README and video I am trying to cache a belongsToMany relationship but it doesn't seem to be working. In my set up caching other relationships does work such as hasOne, hasMany and belongsTo but the many-to-many case does not.

I have had a brief look through the code but I am not following where either it or I could be going wrong. The documentation states that adding the Cachable trait just works including relationships.

I do note however, that the test for relationships only seems to test a single type (many-to-one).

Also note that eagerly loading a relationship does appear to work (ie. using with()) whereas lazy loading does not.

I would appreciate any help. Let me know if you need more info.

PS. This is an awesome library!

Environment

Laravel Version: 5.6.*
Laravel Model Caching Package Version: 0.2.57
PHP Version: 7.2
Homestead Version: N/A
Operating System & Version: ArchLinux

Stack Trace

N/A

[mikebronner]

Hi @jradtilbrook, thanks for reporting these issues. I think perhaps you may have found two holes that haven't been plugged yet. I'll look into it and see if its a bug, or missing functionality. :)

Thanks!

[jradtilbrook]

Awesome, no worries. I'm keen to contribute if you need it so let me know. I'm in the process of tracing through to help find anything. I'll let you know if I do 👍

[mikebronner]

That would be awesome :)

[jradtilbrook]

Looks like it might be this line https://github.com/GeneaLabs/laravel-model-caching/blob/master/src/Traits/ModelCaching.php#L57. The internals of laravel calls that passing in the base query builder which is just a standard eloquent builder. It then uses that to perform the actual query (without caching).

To get around this and not have infinite recursion, the CachedBuilder class may have to override the getModels() method of the parent Builder to not proxy to the default non-cached query, all without a call back to its own get(). See also https://github.com/illuminate/database/blob/master/Eloquent/Builder.php#L492-L517

[mikebronner]

@jradtilbrook looking into this now, to see if I can handle lazy-loading of relationships. You're assessment is spot on. This will take a while to sort out. In the mean time I will clarify in the documentation that lazy-loading is NOT cached.

[jradtilbrook]

No worries. I started looking and thought it might be quite complex so thought I'd leave it for now. Thanks for checking it out and good luck!

[mikebronner]

Any help in form of a PR (by anyone) would be greatly appreciated and help speed things up. :)