Skip to content

Fix 366 #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2024
Merged

Fix 366 #367

merged 2 commits into from
May 22, 2024

Conversation

gajrajgchouhan
Copy link
Contributor

Linked Issue(s)

Closes #366

Acceptance Criteria fulfillment

  • Task 1
  • Task 2
  • Task 3

Proposed changes (including videos or screenshots)

Further comments

@CLAassistant
Copy link

CLAassistant commented May 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gajrajgchouhan
Copy link
Contributor Author

There is a PullRequestsTableMini as well, do I need to change that as well?

@samad-yar-khan
Copy link
Contributor

@e-for-eshaan Can you please look into these front-end changes ?

@e-for-eshaan
Copy link
Contributor

Hey @gajrajgchouhan, thanks for this PR.
The DeploymentInsightsOverlay (the one that opens when you click on the Deployment Frequency card) utilises PullRequestsTableMini. You should remove the redundant copy from there as well.

@gajrajgchouhan
Copy link
Contributor Author

Hi @e-for-eshaan , I have done this.

e-for-eshaan
e-for-eshaan approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@e-for-eshaan e-for-eshaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-for-eshaan e-for-eshaan merged commit 787e2d7 into middlewarehq:main May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kumarajay0412 kumarajay0412 kumarajay0412 approved these changes

@e-for-eshaan e-for-eshaan e-for-eshaan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove User not added tooltip

5 participants

@gajrajgchouhan @CLAassistant @samad-yar-khan @e-for-eshaan @kumarajay0412