Skip to content

Escapes special characters on path segments when using Invoke-MgGraphRequest #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 27, 2023
Merged

Escapes special characters on path segments when using Invoke-MgGraphRequest #2455

merged 6 commits into from
Nov 27, 2023

Conversation

timayabi2020
Copy link
Contributor

Fixes #1947

Changes proposed in this pull request

  • Added function to escape data string/url encode path segments that have special characters like #. Results for both Absolute and relative uri are shown on the image below.
    image

@timayabi2020 timayabi2020 requested a review from a team as a code owner November 21, 2023 11:30
@timayabi2020 timayabi2020 linked an issue Nov 21, 2023 that may be closed by this pull request
Invoke-MgGraphRequest can't handle URI with # #1947
Closed
peombwa
peombwa requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@peombwa peombwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the fix! Please see my suggestions on the PR.

calebkiage
calebkiage reviewed Nov 22, 2023
View reviewed changes
@timayabi2020 timayabi2020 merged commit 0fd3465 into dev Nov 27, 2023
@timayabi2020 timayabi2020 deleted the 1947-invoke-mggraphrequest-cant-handle-uri-with branch November 27, 2023 20:55
@c-baumgartner c-baumgartner mentioned this pull request Dec 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peombwa peombwa peombwa approved these changes

@calebkiage calebkiage Awaiting requested review from calebkiage

+1 more reviewer

@ddyett ddyett ddyett left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoke-MgGraphRequest can't handle URI with #
4 participants
@timayabi2020 @calebkiage @peombwa @ddyett