forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Preliminary support for editing notebooks #7222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rchiodo
merged 20 commits into
microsoft:master
from
IanMatthewHuff:dev/ianhu/editNotebooks3
Sep 6, 2019
Merged
Preliminary support for editing notebooks #7222
rchiodo
merged 20 commits into
microsoft:master
from
IanMatthewHuff:dev/ianhu/editNotebooks3
Sep 6, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Sep 5, 2019
Author
src/client/datascience/interactive-common/interactiveWindowTypes.ts
Outdated
Show resolved
Hide resolved
rchiodo
commented
Sep 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #7222 +/- ##
==========================================
- Coverage 58.55% 58.29% -0.26%
==========================================
Files 486 493 +7
Lines 21460 21661 +201
Branches 3463 3486 +23
==========================================
+ Hits 12566 12628 +62
- Misses 8116 8255 +139
Partials 778 778
Continue to review full report at Codecov.
|
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress, but this submission will add support for editing ipynb files.
There are a number of things left to do, but all functional tests for the existing code base should be passing.
List of stuff left to do can be found in item #5959
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)