Skip to content

Conversation

@rchiodo
Copy link

@rchiodo rchiodo commented Sep 5, 2019

This is still a work in progress, but this submission will add support for editing ipynb files.

There are a number of things left to do, but all functional tests for the existing code base should be passing.

List of stuff left to do can be found in item #5959

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo rchiodo self-assigned this Sep 5, 2019
@rchiodo
Copy link
Author

rchiodo commented Sep 5, 2019

"python.linting.pycodestyleEnabled": false,

I should undo these changes too
#Resolved


Refers to: src/test/.vscode/settings.json:14 in 63170b4. [](commit_id = 63170b4, deletion_comment = True)

@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #7222 into master will decrease coverage by 0.25%.
The diff coverage is 18.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7222      +/-   ##
==========================================
- Coverage   58.55%   58.29%   -0.26%     
==========================================
  Files         486      493       +7     
  Lines       21460    21661     +201     
  Branches     3463     3486      +23     
==========================================
+ Hits        12566    12628      +62     
- Misses       8116     8255     +139     
  Partials      778      778
Impacted Files Coverage Δ
...ascience/jupyter/liveshare/hostJupyterExecution.ts 45.45% <ø> (ø) ⬆️
...activation/languageServer/languageClientFactory.ts 95.12% <ø> (ø) ⬆️
...ractive-common/interactiveWindowMessageListener.ts 20% <ø> (ø)
src/datascience-ui/interactive-common/tokenizer.ts 0% <ø> (ø)
src/client/common/types.ts 100% <ø> (ø) ⬆️
...ence/interactive-common/intellisense/conversion.ts 13.2% <ø> (ø)
...nce/jupyter/liveshare/liveShareParticipantMixin.ts 44.44% <ø> (ø) ⬆️
...active-common/intellisense/intellisenseDocument.ts 58.82% <ø> (ø)
...ence/interactive-common/intellisense/wordHelper.ts 19.67% <ø> (ø)
...ent/datascience/jupyter/jupyterExecutionFactory.ts 75.6% <ø> (ø) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04200d9...d6496ce. Read the comment docs.

@rchiodo rchiodo merged commit 94abff9 into microsoft:master Sep 6, 2019
@rchiodo rchiodo deleted the dev/ianhu/editNotebooks3 branch September 6, 2019 16:39
@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants