Skip to content

Conversation

@IanMatthewHuff
Copy link
Member

For #6907

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff
Copy link
Member Author

Tested with a new environment with no debugger installed. VSCode installed debugger was correctly picked up, debugging worked, and after run ptvsd was not installed into that environment.

@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #7220 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7220      +/-   ##
=========================================
- Coverage   58.55%   58.5%   -0.06%     
=========================================
  Files         486     486              
  Lines       21460   21460              
  Branches     3463    3463              
=========================================
- Hits        12566   12555      -11     
- Misses       8116    8129      +13     
+ Partials      778     776       -2
Impacted Files Coverage Δ
src/client/common/logger.ts 68.55% <0%> (-6.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70b4f5...0c79cc2. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit 20246e9 into microsoft:master Sep 5, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/debuggerInstall branch September 5, 2019 20:56
@lock lock bot locked as resolved and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants