Skip to content

Conversation

@karrtikr
Copy link

@karrtikr karrtikr commented Sep 4, 2019

For #7002

@karrtikr karrtikr added the no-changelog No news entry required label Sep 4, 2019
@karrtikr karrtikr force-pushed the updateContributingGuide branch from bd63b3d to 597c027 Compare September 4, 2019 21:08
@karrtikr karrtikr requested a review from kimadeline September 4, 2019 21:10
@karrtikr karrtikr merged commit 7bd878f into microsoft:master Sep 4, 2019
@karrtikr karrtikr deleted the updateContributingGuide branch September 4, 2019 21:18
@codecov-io
Copy link

codecov-io commented Sep 4, 2019

Codecov Report

Merging #7202 into master will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7202      +/-   ##
=========================================
+ Coverage    58.2%   58.5%   +0.29%     
=========================================
  Files         486     486              
  Lines       21460   21460              
  Branches     3458    3463       +5     
=========================================
+ Hits        12491   12555      +64     
+ Misses       8188    8129      -59     
+ Partials      781     776       -5
Impacted Files Coverage Δ
src/client/common/logger.ts 68.55% <0%> (-4.41%) ⬇️
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 89.65% <0%> (+13.79%) ⬆️
src/client/common/utils/icons.ts 100% <0%> (+16.66%) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (+25%) ⬆️
src/client/api.ts 87.5% <0%> (+25%) ⬆️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (+33.33%) ⬆️
src/client/testing/codeLenses/main.ts 77.77% <0%> (+33.33%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb8d33...597c027. Read the comment docs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants