Skip to content

Conversation

@DavidKutu
Copy link

to 'Run Startup Commands'.

For #6842

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

to 'Run Startup Commands' to avoid confusion.
@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #7163 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7163      +/-   ##
==========================================
- Coverage   58.48%   58.44%   -0.04%     
==========================================
  Files         485      485              
  Lines       21446    21446              
  Branches     3462     3462              
==========================================
- Hits        12542    12535       -7     
- Misses       8123     8135      +12     
+ Partials      781      776       -5
Impacted Files Coverage Δ
src/client/common/types.ts 100% <ø> (ø) ⬆️
...atascience/interactive-window/interactiveWindow.ts 7.38% <0%> (ø) ⬆️
src/client/common/logger.ts 68.55% <0%> (-4.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cf9e0...047cc97. Read the comment docs.

@DavidKutu DavidKutu closed this Aug 30, 2019
@DavidKutu DavidKutu reopened this Aug 30, 2019
@DavidKutu DavidKutu merged commit ef47d38 into master Aug 30, 2019
@DavidKutu DavidKutu deleted the davidkutu/change_setting_name branch August 30, 2019 21:24
@lock lock bot locked as resolved and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants